feat: resolve repo UUID for gRPC calls via REST API#8
Merged
markovejnovic merged 3 commits intostagedfrom Feb 27, 2026
Merged
Conversation
Mesa DescriptionSummary
This is a breaking API change. Test plan
Description generated by Mesa. Update settings |
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 0141cd1...7b17121
Analysis
- Build script requires proto sources at compile time, but these sources are not versioned, which will break downstream builds.
- gRPC runtime dependencies are added unconditionally without feature gates, forcing all consumers to inherit a heavy async stack before any gRPC API surface exists.
- The PR leaves the application-layer implementation incomplete - needs either committed proto definitions with generated bindings or feature-gated build steps.
- Current implementation will prevent the existing REST client from building until the gRPC components are fully implemented.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
0 files reviewed | 1 comments | Edit Agent Settings • Read Docs
markovejnovic
force-pushed
the
feat/grpc
branch
from
98b450f to
ce2d999
Compare
markovejnovic
force-pushed
the
feat/grpc
branch
from
a53800d to
d6399e1
Compare
markovejnovic
force-pushed
the
feat/grpc
branch
from
73c537a to
8f53b24
Compare
markovejnovic
changed the title
markovejnovic
force-pushed
the
feat/grpc
branch
from
15c55e7 to
aeea4d3
Compare
These APIs were removed from the generated OAPI crate in the rebase target. Drop the corresponding high-level client wrappers and test references.
markovejnovic
force-pushed
the
feat/grpc
branch
from
aeea4d3 to
799c29a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RepoClient::change()is nowasync— fetches repo metadata via REST to get the UUID expected by the gRPC data planeChangeClient::new()acceptsrepo_id: String(UUID) instead oforg/repoChangeClienttrackslast_op_idviaAtomicU64and passes it asexpected_last_op_idinapply_opsandsnapshotrequests (required by server)This is a breaking API change.
Test plan
cargo check -p mesa-devcompilescargo test --workspace --no-runcompileshl_create_change— PASS on staginghl_create_file(apply_ops + snapshot) — PASS on staginghl_delete_file— PASS on staginghl_modify_file— PASS on staginghl_move_file— PASS on staginghl_write_then_read— REST content read-back returns FILE_NOT_FOUND after successful gRPC snapshot (staging propagation issue)